Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery dependency completely #1355

Merged
merged 5 commits into from Jun 7, 2022
Merged

Remove jQuery dependency completely #1355

merged 5 commits into from Jun 7, 2022

Conversation

rht
Copy link
Contributor

@rht rht commented Jun 7, 2022

Fixes #1318.

I tested on the same checklist in #1325:

  • Check that the start/step/reset works
  • Check that on mobile view, the start/step/reset is hidden by the hamburger button
  • Check the frame per second input works
  • Check the modal (the about button) fades in/out correctly
  • Check the user input title shows up correctly
  • Check the user input description hover text appears correctly
  • Check all the user inputs:
    • slider (boltzmann_wealth_model)
    • choice (pd_grid)
    • boolean switch (wolf_sheep)
    • raw text (virus_on_network)
    • number (no need to check this, because it's not in the examples, and I already check this myself)

Additionally, I tested all the modules:

  • canvas grid, bar chart, pie chart, chart (using the charts example)
  • network (using the virus_on_network example)
  • hex grid (using the hex_snowflake example)

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1355 (b6538ed) into main (9a78551) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1355   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files          18       18           
  Lines        1352     1352           
  Branches      260      260           
=======================================
  Hits         1232     1232           
  Misses         85       85           
  Partials       35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a78551...b6538ed. Read the comment docs.

Copy link
Contributor

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit df47fb3 into projectmesa:main Jun 7, 2022
@rht rht deleted the no_jquery branch June 7, 2022 12:44
@jackiekazil jackiekazil added this to the Quartzsite (next release) milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Remove dependency on jQuery
3 participants