-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move viz stuff to mesa-viz-tornado Git repo #1746
Conversation
This greatly simplifies the setup.py, and we should be able to move to setup.cfg+pyproject.toml very soon. |
28cbf2c
to
f4825ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So my understanding is #1747 fixes the build fails; but what about the lint-ruff fails that the imports are unsorted?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1746 +/- ##
==========================================
+ Coverage 72.35% 80.66% +8.31%
==========================================
Files 20 15 -5
Lines 1302 869 -433
Branches 246 183 -63
==========================================
- Hits 942 701 -241
+ Misses 325 147 -178
+ Partials 35 21 -14
☔ View full report in Codecov by Sentry. |
One main blocker to this PR is that the dependencies once again include a Git repo. mesa-viz-tornado needs to be released as a PyPI package first. |
Another blocker is that the API documentation no longer shows the viz stuff: https://mesa--1746.org.readthedocs.build/en/1746/apis/visualization.html. Either create a separate RTD for mesa-viz-tornado, or just tell people to read the source code directly. Either way, I'd rather spend effort on completing the Solara viz features than on this. |
Just to be overly explicit, the plan is to merge this, but before we do another PyPI release create a mesa-viz-tornado package so the release doesn't break. As for updates to the RTD, I can work on that, but concur to keep working Solara, based on the feedback we have already received. |
This may sound like I'm running away from the responsibility of ensuring that the existing viz API documentation persists. I meant it as prioritization for my time allocation. |
It doesn't your fine, we are always running on limited bandwidth we have to prioritize and python front end has been our # 1 feedback so Solara has to be the priority |
No description provided.