Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move viz stuff to mesa-viz-tornado Git repo #1746

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

rht
Copy link
Contributor

@rht rht commented Jul 31, 2023

No description provided.

@rht
Copy link
Contributor Author

rht commented Jul 31, 2023

This greatly simplifies the setup.py, and we should be able to move to setup.cfg+pyproject.toml very soon.

@rht rht force-pushed the mesa-viz-tornado branch 3 times, most recently from 28cbf2c to f4825ec Compare July 31, 2023 16:47
tpike3

This comment was marked as duplicate.

Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So my understanding is #1747 fixes the build fails; but what about the lint-ruff fails that the imports are unsorted?

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: +8.31% 🎉

Comparison is base (856d4bc) 72.35% compared to head (f3c4f70) 80.66%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1746      +/-   ##
==========================================
+ Coverage   72.35%   80.66%   +8.31%     
==========================================
  Files          20       15       -5     
  Lines        1302      869     -433     
  Branches      246      183      -63     
==========================================
- Hits          942      701     -241     
+ Misses        325      147     -178     
+ Partials       35       21      -14     
Files Changed Coverage Δ
mesa/visualization/TextVisualization.py 0.00% <0.00%> (-39.48%) ⬇️
mesa/__init__.py 100.00% <100.00%> (ø)
mesa/visualization/ModularVisualization.py 100.00% <100.00%> (+32.72%) ⬆️
mesa/visualization/UserParam.py 100.00% <100.00%> (ø)
mesa/visualization/__init__.py 100.00% <100.00%> (ø)
mesa/visualization/modules.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rht
Copy link
Contributor Author

rht commented Aug 4, 2023

One main blocker to this PR is that the dependencies once again include a Git repo. mesa-viz-tornado needs to be released as a PyPI package first.

@rht
Copy link
Contributor Author

rht commented Aug 4, 2023

Another blocker is that the API documentation no longer shows the viz stuff: https://mesa--1746.org.readthedocs.build/en/1746/apis/visualization.html. Either create a separate RTD for mesa-viz-tornado, or just tell people to read the source code directly. Either way, I'd rather spend effort on completing the Solara viz features than on this.

@tpike3
Copy link
Member

tpike3 commented Aug 4, 2023

Just to be overly explicit, the plan is to merge this, but before we do another PyPI release create a mesa-viz-tornado package so the release doesn't break.

As for updates to the RTD, I can work on that, but concur to keep working Solara, based on the feedback we have already received.

@rht
Copy link
Contributor Author

rht commented Aug 4, 2023

Either way, I'd rather spend effort on completing the Solara viz features than on this.

This may sound like I'm running away from the responsibility of ensuring that the existing viz API documentation persists. I meant it as prioritization for my time allocation.

@tpike3
Copy link
Member

tpike3 commented Aug 4, 2023

Either way, I'd rather spend effort on completing the Solara viz features than on this.

This may sound like I'm running away from the responsibility of ensuring that the existing viz API documentation persists. I meant it as prioritization for my time allocation.

It doesn't your fine, we are always running on limited bandwidth we have to prioritize and python front end has been our # 1 feedback so Solara has to be the priority

@tpike3 tpike3 merged commit 1ea0dc7 into projectmesa:main Aug 7, 2023
11 checks passed
@tpike3 tpike3 added this to the Release 2.1.2 milestone Sep 19, 2023
@tpike3 tpike3 mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants