Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Define current_step as reactive #1875

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

rht
Copy link
Contributor

@rht rht commented Nov 15, 2023

This should reduce the number of arguments that needs to be passed to the components.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (f2f4d1e) 77.10% compared to head (33b65cc) 77.10%.

Files Patch % Lines
mesa/experimental/jupyter_viz.py 40.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1875   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          15       15           
  Lines         974      974           
  Branches      213      213           
=======================================
  Hits          751      751           
  Misses        195      195           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This should reduce the number of arguments that needs to be passed to
the components.
Copy link
Contributor

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit eb7d439 into projectmesa:main Nov 16, 2023
14 of 15 checks passed
@rht rht deleted the solara branch November 16, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants