Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert make_space into Solara component #1877

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

rht
Copy link
Contributor

@rht rht commented Nov 15, 2023

Depends on #1875 to be merged first.

@rht rht force-pushed the solara2 branch 3 times, most recently from 0c6d7c3 to 60bc0a8 Compare November 15, 2023 11:00
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2a42f90) 77.05% compared to head (5ad6e37) 77.10%.

Files Patch % Lines
mesa/experimental/jupyter_viz.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
+ Coverage   77.05%   77.10%   +0.04%     
==========================================
  Files          15       15              
  Lines         972      974       +2     
  Branches      213      214       +1     
==========================================
+ Hits          749      751       +2     
  Misses        195      195              
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rht rht force-pushed the solara2 branch 3 times, most recently from 047438f to dabf6f1 Compare November 16, 2023 11:23
@tpike3
Copy link
Member

tpike3 commented Nov 19, 2023

This is failing the python 3.8 and python 3.9 build---

def SpaceMatplotlib(model, agent_portrayal, dependencies: List[Any] | None = None):
E   TypeError: unsupported operand type(s) for |: '_GenericAlias' and 'NoneType'

@rht
Copy link
Contributor Author

rht commented Nov 19, 2023

Fixed.

Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit 899767e into projectmesa:main Nov 20, 2023
14 of 15 checks passed
@rht rht deleted the solara2 branch November 20, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants