Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert README.rst to README.md via pandoc #1881

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

rht
Copy link
Contributor

@rht rht commented Nov 17, 2023

No description provided.

@rht
Copy link
Contributor Author

rht commented Nov 17, 2023

This breaks the Sphinx build, because it needs README.rst. It means I have to convert all the remaining RST files in 1 PR.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a42f90) 77.05% compared to head (50a3ff6) 77.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1881   +/-   ##
=======================================
  Coverage   77.05%   77.05%           
=======================================
  Files          15       15           
  Lines         972      972           
  Branches      213      213           
=======================================
  Hits          749      749           
  Misses        195      195           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rht rht force-pushed the rst-to-md branch 5 times, most recently from e7e09f3 to aee932a Compare November 17, 2023 11:54
@rht
Copy link
Contributor Author

rht commented Nov 17, 2023

It seems to work without having me converting the docs to .md. However, this PR depends on #1870 to be merged.

@rht rht force-pushed the rst-to-md branch 2 times, most recently from 1d40995 to 25200ce Compare November 17, 2023 11:59
@tpike3
Copy link
Contributor

tpike3 commented Nov 17, 2023

It seems to work without having me converting the docs to .md. However, this PR depends on #1870 to be merged.

Does it depend on #1870, it looks like it supersedes it?

@rht rht force-pushed the rst-to-md branch 2 times, most recently from aab664e to a59c0ed Compare November 17, 2023 12:01
@rht
Copy link
Contributor Author

rht commented Nov 17, 2023

It has a commit from #1870, but that commit will disappear once I rebase. I am building this PR over #1870 to prevent a redo due to merge conflict.

@rht
Copy link
Contributor Author

rht commented Nov 19, 2023

Rebased. This PR is ready.

@rht rht changed the title Convert README.md to README.rst via pandoc Convert README.rst to README.md via pandoc Nov 20, 2023
Copy link
Contributor

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM--- Thanks @rht!!

@tpike3 tpike3 merged commit 3f6a6b6 into projectmesa:main Nov 20, 2023
15 checks passed
@rht rht deleted the rst-to-md branch November 20, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants