Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate setup from setup.py to pyproject.toml #1870

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

rht
Copy link
Contributor

@rht rht commented Nov 8, 2023

No description provided.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e58b4da) 77.05% compared to head (23e23a0) 77.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1870   +/-   ##
=======================================
  Coverage   77.05%   77.05%           
=======================================
  Files          15       15           
  Lines         972      972           
  Branches      213      213           
=======================================
  Hits          749      749           
  Misses        195      195           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rht rht force-pushed the setup branch 6 times, most recently from 060a535 to 35c1fe9 Compare November 13, 2023 11:55
@rht
Copy link
Contributor Author

rht commented Nov 17, 2023

This PR is needed so that the requirements can be pinned, and that pyproject.toml is a declarative file that can be scanned by Dependabot https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions, and to seamlessly migrate to Poetry with a lockfile.

Remove Tornado external dep files from MANIFEST.in

Apply Black

pyproject.toml: Dynamically read version from __init__.py
Copy link
Contributor

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit 2a42f90 into projectmesa:main Nov 19, 2023
15 checks passed
@rht rht deleted the setup branch November 19, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants