Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add tests for mesa-examples #1956

Merged
merged 1 commit into from
Jan 12, 2024
Merged

ci: Add tests for mesa-examples #1956

merged 1 commit into from
Jan 12, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Jan 11, 2024

No description provided.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d48db5) 79.45% compared to head (1039e96) 79.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1956   +/-   ##
=======================================
  Coverage   79.45%   79.45%           
=======================================
  Files          15       15           
  Lines        1285     1285           
  Branches      285      285           
=======================================
  Hits         1021     1021           
  Misses        225      225           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rht rht requested review from Corvince and EwoutH January 11, 2024 12:49
Copy link
Contributor

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level, looks good. Obviously the examples need to be fixed, but that can be done in another PR.

Thanks!

@EwoutH EwoutH added testing Release notes label ci Release notes label labels Jan 11, 2024
@Corvince
Copy link
Contributor

Agree with @EwoutH but we shouldn't merge just yet - otherwise we have a failing CI until the issues are resolved. But PR is super fine.

@rht
Copy link
Contributor Author

rht commented Jan 12, 2024

I need to merge this so that I can debug the weakref stuff in another PR.

@rht rht merged commit 36da145 into projectmesa:main Jan 12, 2024
12 of 13 checks passed
@rht rht deleted the test_examples branch January 12, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Release notes label testing Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants