Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release PR - Nogales Mesa 0.8.8 #957

Merged
merged 12 commits into from
Nov 24, 2020
Merged

Release PR - Nogales Mesa 0.8.8 #957

merged 12 commits into from
Nov 24, 2020

Conversation

jackiekazil
Copy link
Member

Let em know if I missed anything in the history. Feel free to edit in the branch.
Also, I did a sample push to testpypi - https://test.pypi.org/project/Mesa/

@jackiekazil jackiekazil added this to the Nogales milestone Nov 19, 2020
@jackiekazil jackiekazil mentioned this pull request Nov 19, 2020
Closed
@codecov
Copy link

codecov bot commented Nov 19, 2020 •
edited
Loading

Codecov Report

Merging #957 (20bce5f) into master (1958630) will increase coverage by 1.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
+ Coverage   88.73%   89.88%   +1.14%     
==========================================
  Files          19       19              
  Lines        1136     1275     +139     
  Branches      190      251      +61     
==========================================
+ Hits         1008     1146     +138     
- Misses         93       98       +5     
+ Partials       35       31       -4
Impacted Files Coverage Δ
mesa/__init__.py 100.00% <100.00%> (ø)
mesa/datacollection.py 97.77% <0.00%> (+0.07%) ⬆️
mesa/visualization/ModularVisualization.py 76.12% <0.00%> (+0.51%) ⬆️
mesa/time.py 98.92% <0.00%> (+3.40%) ⬆️
mesa/batchrunner.py 93.85% <0.00%> (+3.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1958630...20bce5f. Read the comment docs.

@jackiekazil
Copy link
Member Author

@tpike3 @Corvince @dmasad can one you do a quick review on this?

@jackiekazil jackiekazil mentioned this pull request Nov 20, 2020
Open
tpike3
tpike3 approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tpike3
Copy link
Member

tpike3 commented Nov 21, 2020 via email

@dmasad
Copy link
Member

dmasad commented Nov 21, 2020

Looks good to me too!

@Corvince
Copy link
Contributor

On a quick look I saw a few spelling mistakes, but am on mobile so I correct them later

@jackiekazil
Copy link
Member Author

I added a few things that were missing & updated some grammar.
I also updated the date for tomorrow.
@Corvince let us know when you did your review, updates (unless I already caught them)

@Corvince
Copy link
Contributor

Two minor typos fixed. Maybe we should mention this is the last version to support Python 3.5? Since we removed it from travis and it reached EOL we really shouldn't care about it any more (for example there are recent issues probably related to dictionaries being unordered and f-strings are amazing)

@jackiekazil
Copy link
Member Author

@Corvince good catch. I added a note at the time.

@ All - I feel good with this if someone could merge. I will release.

@jackiekazil
Copy link
Member Author

Updated the date since it looks like this will happen tomorrow.

@tpike3 tpike3 merged commit 221d4a9 into master Nov 24, 2020
@EwoutH EwoutH deleted the nogales branch September 20, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpike3 tpike3 tpike3 approved these changes

Assignees
No one assigned
Labels
3 - Accept
Projects
None yet
Milestone
Nogales
Development

Successfully merging this pull request may close these issues.
4 participants
@jackiekazil @tpike3 @dmasad @Corvince