Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-277 few null checks to avoid crash when node went under bottom … #384

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DanieLazarLDAPPS
Copy link
Contributor

@DanieLazarLDAPPS DanieLazarLDAPPS commented Aug 7, 2019

Checklist

  • The code has been run through pretty yarn run pretty
  • The tests pass on CircleCI
  • You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • The PR Template has been filled out (see below)
  • Had a beer because you are awesome

What?

Issue with smart routing

Why?

Because of this issue
#277

How?

I just went thru errors reported by the console and I added few null checks and it fixed that issue. But I have no idea if there will be some deeper dependency so please check it out. Thank you

Feel-Good "programming lol" image:

(Add your own one below :])

LOL

@@ -275,6 +275,9 @@ export class DiagramEngine extends BaseEntity<DiagramEngineListener> {
}

getNodeElement(node: NodeModel): Element {
if (!this.canvas) {
Copy link
Contributor Author

@DanieLazarLDAPPS DanieLazarLDAPPS Aug 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the node is under the bottom of the screen canvas is null.

Copy link
Contributor

@frank-martinez-27 frank-martinez-27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dylanvorster
Copy link
Member

Are you able to port these fixes to the new 6.0 version?

@DanieLazarLDAPPS
Copy link
Contributor Author

Yeap I will

@DanieLazarLDAPPS DanieLazarLDAPPS force-pushed the bugfix/#277-smart-route-canvas-null-check branch from a978a9a to 264c74e Compare August 13, 2019 06:46
@DanieLazarLDAPPS
Copy link
Contributor Author

Hi @dylanvorster, well I migrated fixes to 6 version but unfortunately, it won't help. Please check following gif how to reproduce this error. The problem is in PathFinderLinkWidget.
smartroutebug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants