fix(cdk8s): deprecate cdk8sPlusVersion option #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REFACTOR: removes cdk8sPlusVersion options Signed-off-by: Hunter Thompson <aatman@auroville.org.in>
Codecov Report
@@ Coverage Diff @@
## main #1273 +/- ##
==========================================
+ Coverage 78.46% 87.74% +9.27%
==========================================
Files 88 129 +41
Lines 3181 4879 +1698
Branches 809 1259 +450
==========================================
+ Hits 2496 4281 +1785
+ Misses 683 560 -123
- Partials 2 38 +36
Continue to review full report at Codecov.
|
eladb
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REFACTOR: removes cdk8sPlusVersion options
Signed-off-by: Hunter Thompson aatman@auroville.org.in
Closes #1272
BREAKING CHANGE:
cdk8s-plusis not included automatically in cdk8s project. Users need to add this dependency explicitly.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.