Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React project #158

Closed
eladb opened this issue Oct 5, 2020 · 1 comment
Closed

React project #158

eladb opened this issue Oct 5, 2020 · 1 comment

Comments

@eladb
Copy link
Contributor

eladb commented Oct 5, 2020 •
edited

Reference from @harrysolovay: https://github.com/harrysolovay/react-templates-are-evil
@Chriscbr Chriscbr mentioned this issue Oct 7, 2020
Merged
mergify bot pushed a commit that referenced this issue Oct 13, 2020
@Chriscbr
feat(nextjs): add support for nextjs projects (#167)
2613604 
*Issue #, if available:* relates to #158 

*Description of changes:* adds support for NextJS projects

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
@kcwinner kcwinner mentioned this issue Oct 26, 2020
Merged
mergify bot referenced this issue Oct 26, 2020
@kcwinner
Feat/create react app v4 (#229)
911b893 
*Issue #, if available:* [158](https://github.com/eladb/projen/issues/158)

*Description of changes:*
* Adds new project `react`
* Adds new project `react-ts`
* Adds a new option to tsconfig options that react expects - `allowSyntheticDefaultImports`

Something to discuss - should the output files use:
1. `fs.writeFileSync(path.join(srcdir, 'logo.svg'), logoSvg.join('\n'));` - just joins the string array
1. `new ReactAppTest(this.project, path.join(srcdir, 'App.test.' + this.fileExt));` - extends `FileBase`

I left both options as examples in the code. Either to swap either way. 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
@eladb
Copy link
Contributor Author

eladb commented Oct 27, 2020

Resolved by #229

@eladb eladb closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eladb