Feat/create react app v4 #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
approved these changes
Oct 26, 2020
eladb
suggested changes
Oct 26, 2020
eladb
reviewed
Oct 26, 2020
eladb
reviewed
Oct 26, 2020
|
|
||
| fs.mkdirpSync(assetsdir); | ||
|
|
||
| const indexHtml = [ |
There was a problem hiding this comment.
Might make sense to store this in a separate file and fs.readFile
| 'export default reportWebVitals;', | ||
| ]; | ||
|
|
||
| fs.mkdirpSync(srcdir); |
There was a problem hiding this comment.
See the PR @mbonig is working on. I think we'll have something like SampleDir which will accept multiple files.
There was a problem hiding this comment.
I can go back and clean this up once that PR is in!
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2020
*Issue #, if available:* N/A *Description of changes:* Fix currently failing build caused by merging of #228 and #229 to master Also fixed categorization of some commands By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Closed
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2020
Addresses some comments from #229 I ran `diff` against the two folders to check the same files are generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 158
Description of changes:
reactreact-tsallowSyntheticDefaultImportsSomething to discuss - should the output files use:
fs.writeFileSync(path.join(srcdir, 'logo.svg'), logoSvg.join('\n'));- just joins the string arraynew ReactAppTest(this.project, path.join(srcdir, 'App.test.' + this.fileExt));- extendsFileBaseI left both options as examples in the code. Either to swap either way.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.