fix(project): runTaskCommand() ignores projenCommand
#3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
changed the title
runTaskCommand to Tasks component and deprecate other implementationsproject.runTaskCommand(task) in favor of new project.tasks.runTaskCommand(task)
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3293 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 191 191
Lines 36488 36497 +9
Branches 3399 3400 +1
=======================================
+ Hits 35147 35157 +10
+ Misses 1341 1340 -1 ☔ View full report in Codecov by Sentry. |
mrgrain
force-pushed
the
mrgrain/fix/run-task-command-ignores-projen-command
branch
from
0e5d763
to
1f53e76
Compare
mrgrain
changed the title
project.runTaskCommand(task) in favor of new project.tasks.runTaskCommand(task)runTaskCommand() ignores projenCommand
mrgrain
force-pushed
the
mrgrain/fix/run-task-command-ignores-projen-command
branch
from
1f53e76
to
470a67a
Compare
rix0rrr
approved these changes
Jan 26, 2024
mrgrain
changed the title
runTaskCommand() ignores projenCommandrunTaskCommand() ignores projenCommand
mergify
bot
deleted the
mrgrain/fix/run-task-command-ignores-projen-command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation of
runTaskCommand()onProjecthas a bug that is causing it ignore the value ofprojenCommand.While looking at fixing this, I noticed a bunch of inconsistency in this area. For example
NodeProjecthas its own implementation ofrunTaskCommand()andNodePackagehas a customprojenCommand, which I deprecated. There's also some inconsistency of whenprojenCommandis used directly vs. whenrunTaskCommand()is used and both have a different default value.I don't have time to sort out this mess right now, because both "easy fixes" have some wider implications:
npx projen@<version>the default forprojenCommandfeels safer, but would cause all generated files to update the header all the timenpx projeninrunTaskCommand()seems less safe for languages that don't have the projen version locked in a lockfile.Thus I have focused on fixing the bug at hand. This is a low hanging fruit albeit the implementation is a bit akward.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.