Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "NODE_ENV test affects projen behavior" #3334

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Feb 7, 2024

Original issue: #2947
Reverts #3294
Fixes #3322 (reply in thread)

This unintentional caused tests of custom projen projects to fail. We will need a different solution for the original issue.


"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license."

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb6b12f) 96.39% compared to head (dab40b3) 96.39%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3334   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         191      191           
  Lines       36554    36554           
  Branches     3413     3413           
=======================================
+ Hits        35236    35238    +2     
+ Misses       1318     1316    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit 74fb390 into main Feb 7, 2024
14 checks passed
@mergify mergify bot deleted the revert-3294-mrgrain/fix/test-runs branch February 7, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants