chore: fix missing type in building your own project docs #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3407 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 191 191
Lines 37362 37362
Branches 3486 3486
=======================================
+ Hits 36011 36013 +2
+ Misses 1351 1349 -2 ☔ View full report in Codecov by Sentry. |
mrgrain
reviewed
Feb 28, 2024
mrgrain
requested changes
Feb 28, 2024
Co-authored-by: Momo Kornher <mail@moritzkornher.de>
|
@mrgrain The failure is caused by |
|
Hey, I am no longer the maintainer here :-) |
|
|
added 2 commits
February 28, 2024 22:50
This reverts commit bc4b5db.
|
Great! Reverting the changes to defaultReleaseBranch. |
mrgrain
approved these changes
Feb 28, 2024
mrgrain
changed the title
mrgrain
changed the title
mrgrain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
prMention missing in the MyMicroserviceProjectOptions interface
defaultReleaseBranch shouldn't be there in the example because this example should solely help with the goal of adding new prMention property, not dragging in what the default options the parent class has.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.