Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CancellationTokens support in ScrapeHandler #164

Closed
utybo opened this issue Jan 3, 2022 · 2 comments · Fixed by #167
Closed

CancellationTokens support in ScrapeHandler #164

utybo opened this issue Jan 3, 2022 · 2 comments · Fixed by #167
Assignees
@phnx47
Labels
enhancement
Milestone
5.0

Comments

@utybo
Copy link

utybo commented Jan 3, 2022

Hi! First of all, thank you for your work on Prometheus.Client.

While migrating an application from prometheus-net to Prometheus.Client, I noticed that prometheus-net's ICollectorRegistry supports CancellationTokens, while Prometheus.Client's ScrapeHandler does not. It does not seem like the underlying ICollector functions support cancellation tokens either, unfortunately. Would there be a way to add such support?
@phnx47 phnx47 self-assigned this Jan 3, 2022
@phnx47
Copy link
Member

phnx47 commented Jan 3, 2022

@utybo Thank you for the issue. I will investigate this

@phnx47 phnx47 added this to the 5.0 milestone Jan 4, 2022
@phnx47
Copy link
Member

phnx47 commented Jan 4, 2022

It is planned for the next major release

phnx47 added a commit that referenced this issue Jan 4, 2022
@phnx47
feat!: add CancellationToken to IMetricsWriter
fc9900c 
Refs: #164
@phnx47 phnx47 mentioned this issue Jan 4, 2022
Merged
@phnx47 phnx47 linked a pull request Jan 4, 2022 that will close this issue
Add CancellationToken to IMetricsWriter #167
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phnx47 phnx47

Labels
enhancement
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

Add CancellationToken to IMetricsWriter prom-client-net/prom-client
2 participants
@phnx47 @utybo