Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error log to include scrape_id #120

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Fix error log to include scrape_id #120

merged 1 commit into from
Feb 12, 2022

Conversation

chattarajoy
Copy link
Contributor

Since h.coordinator.ScrapeResult deletes the header "Id", the error log that executes post this always prints scrape_id as empty causing issues when debugging.

This change is to store the scrape_id before performing ScrapeResult and using the same in the subsequent error log.

@chattarajoy
Fix error log to include scrape_id
ffc9de7 
Signed-off-by: GitHub <noreply@github.com>
@chattarajoy
Copy link
Contributor Author

@SuperQ can you please review this minor change?

SuperQ
SuperQ approved these changes Feb 12, 2022
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SuperQ SuperQ merged commit ed5e271 into prometheus-community:master Feb 12, 2022
@chattarajoy chattarajoy deleted the fixErrorlog branch February 12, 2022 13:21
SuperQ added a commit that referenced this pull request Mar 28, 2024
@SuperQ
Release v0.2.0
1564720 
* [FEATURE] Implement flags to control retry delays #83
* [ENHANCEMENT] Add scrape_id to error log #120
* [BUGFIX] /clients endpoint return application/json as Content-Type #121

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Mar 28, 2024
Merged
SuperQ added a commit that referenced this pull request Mar 29, 2024
@SuperQ
Release v0.2.0
eb5bc8f 
* [FEATURE] Implement flags to control retry delays #83
* [ENHANCEMENT] Add scrape_id to error log #120
* [BUGFIX] /clients endpoint return application/json as Content-Type #121

Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chattarajoy @SuperQ