Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix /clients endpoint to return application/json Content-Type #121

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Fix /clients endpoint to return application/json Content-Type #121

merged 1 commit into from
Feb 11, 2022

Conversation

odormond
Copy link
Contributor

@odormond odormond commented Feb 7, 2022

Due to the Content-Type returned by the /clients endpoint (text/plain instead of application/json) it’s not possible to hook it directly to Prometheus through its http_sd_config.

This PR fixes that.

@odormond odormond mentioned this pull request Feb 7, 2022
Open
@marco-m-pix4d
Copy link

Nice one, thanks.

@odormond
Fix /clients endpoint to return application/json Content-Type
4bc6631 
Signed-off-by: Olivier Dormond <olivier.dormond@pix4d.com>
SuperQ
SuperQ approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ merged commit e4b868f into prometheus-community:master Feb 11, 2022
@odormond odormond deleted the fix_content_type_returned_by_clients branch February 14, 2022 15:21
SuperQ added a commit that referenced this pull request Mar 28, 2024
@SuperQ
Release v0.2.0
1564720 
* [FEATURE] Implement flags to control retry delays #83
* [ENHANCEMENT] Add scrape_id to error log #120
* [BUGFIX] /clients endpoint return application/json as Content-Type #121

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Mar 28, 2024
Merged
SuperQ added a commit that referenced this pull request Mar 29, 2024
@SuperQ
Release v0.2.0
eb5bc8f 
* [FEATURE] Implement flags to control retry delays #83
* [ENHANCEMENT] Add scrape_id to error log #120
* [BUGFIX] /clients endpoint return application/json as Content-Type #121

Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@odormond @marco-m-pix4d @SuperQ