-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: semantic releases and automatic changelog. #26
Conversation
Signed-off-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: gardar <gardar@users.noreply.github.com>
CC: @SuperQ |
The CI failures on this PR are caused because some of the workflow actions are expecting to find a config on the default branch, so they should only be present on this initial PR. |
Signed-off-by: gardar <gardar@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor nit.
Signed-off-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: gardar <gardar@users.noreply.github.com>
779c4f4 Disabled the auto publish for now in favor of a draft, we can re-enable it later once the collection reaches a production ready stage. |
Both the changelog and collection build/publish workflows use semantic versioning and conventional commits to avoid toil.
We need to manually publish one release that has a semantic version (currently the latest version is tagged as
latest
). After that the workflow can take care of the rest.I didn't want to add complexity to the workflow by supporting a non-semantic version label that's only going to be used initially.