fix(mysqld_exporter): Change condition for mysqld_exporter_host check #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the condition for
mysqld_exporter_host
in the mysqld_exporter my_cnf.j2 template to address an issue wheremysqld_exporter_host: null
in roles/defaults/main.yml was not being handled correctly. The updated condition ensures the host setting logic operates properly even whenmysqld_exporter_host
is set to null.I also think a useful approach would be to simply remove mysqld_exporter_host[port] from defaults/main.yml and not change the template condition. I would appreciate your comments on this.