Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add healthcheck #15

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Conversation

grzesuav
Copy link
Contributor

No description provided.

@grzesuav grzesuav mentioned this pull request Dec 18, 2020
Copy link
Contributor

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

Generally it looks good to me. Would you fix the merge conflict (sorry about that, I just updated the dependencies), then I will merge this!

Signed-off-by: grzesuav <grzesuav@gmail.com>
@grzesuav
Copy link
Contributor Author

hi @csmarchbanks , rebased

Copy link
Contributor

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@csmarchbanks csmarchbanks merged commit 0c1c64c into prometheus-community:master Dec 28, 2020
@grzesuav grzesuav deleted the health branch December 28, 2020 19:39
jt-kloudfuse pushed a commit to kloudfuse/avalanche that referenced this pull request Mar 23, 2021
Signed-off-by: grzesuav <grzesuav@gmail.com>
jt-kloudfuse pushed a commit to kloudfuse/avalanche that referenced this pull request Mar 23, 2021
Signed-off-by: grzesuav <grzesuav@gmail.com>
jt-kloudfuse added a commit to kloudfuse/avalanche that referenced this pull request Mar 24, 2021
* feat: Add healthcheck (prometheus-community#15)

Signed-off-by: grzesuav <grzesuav@gmail.com>

* Refactored metrics generation logic

- Support for multiple metric names
- Support for variable cardinality labels
- Removed remote write code for now
- Refactored code from serve.go into separate module

Signed-off-by: JT <jt@kloudfuse.com>

* Addressed review comments

- Fixed type
- Used logrus unfirmaly
- Defer for unlocking mutex

Signed-off-by: JT <jt@kloudfuse.com>

Co-authored-by: Grzegorz Głąb <grzesuav@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants