Jagan/label cardinality #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jt-kloudfuse
commented
Mar 23, 2021
jt-kloudfuse
commented
Signed-off-by: grzesuav <grzesuav@gmail.com>
- Support for multiple metric names - Support for variable cardinality labels - Removed remote write code for now - Refactored code from serve.go into separate module Signed-off-by: JT <jt@kloudfuse.com>
jt-kloudfuse
force-pushed
the
jagan/label-cardinality
branch
from
8b7ee4b
to
bd32aa8
Compare
ashishkf
reviewed
Mar 24, 2021
ashishkf
approved these changes
Mar 24, 2021
- Fixed type - Used logrus unfirmaly - Defer for unlocking mutex Signed-off-by: JT <jt@kloudfuse.com>
jt-kloudfuse
force-pushed
the
jagan/label-cardinality
branch
from
2425ae3
to
184c7c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.