[kube-prometheus-stack] Scope CoreDNS dashboard to CoreDNS job #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
requested review from
andrewgkew,
bismarck,
desaintmartin,
gianrubio,
gkarthiks,
scottrigby and
Xtigyro
as code owners
monotek
requested changes
Jan 19, 2022
Signed-off-by: GitHub <noreply@github.com>
monotek
previously approved these changes
Jan 20, 2022
|
Thanks! Could you rebase? |
Signed-off-by: André Bauer <andre.bauer@staffbase.com>
desaintmartin
approved these changes
Feb 7, 2022
monotek
approved these changes
Feb 7, 2022
6 tasks
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
…theus-community#1730) * [kube-prometheus-stack] Scope CoreDNS dashboard to CoreDNS job Signed-off-by: GitHub <noreply@github.com> * fix version Signed-off-by: André Bauer <andre.bauer@staffbase.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com> Co-authored-by: André Bauer <andre.bauer@staffbase.com>
This was referenced Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR scopes the metrics shown in the CoreDNS dashboard to the CoreDNS job metrics (excluding node local dns)
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter])