[kube-prometheus-stack] Update CoreDNS Dashboard. Add job template variable #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stian Øvrevåge <sovrevage@gmail.com>
StianOvrevage
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
zeritti
changed the title
Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com>
QuentinBisson
approved these changes
Oct 18, 2023
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Oct 20, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kube-prometheus-stack](https://github.com/prometheus-operator/kube-prometheus) ([source](https://github.com/prometheus-community/helm-charts)) | patch | `51.9.1` -> `51.9.4` | --- ### Release Notes <details> <summary>prometheus-community/helm-charts (kube-prometheus-stack)</summary> ### [`v51.9.4`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.9.4) [Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-51.9.3...kube-prometheus-stack-51.9.4) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Update CoreDNS Dashboard. Add job template variable by [@​StianOvrevage](https://github.com/StianOvrevage) in prometheus-community/helm-charts#3798 #### New Contributors - [@​StianOvrevage](https://github.com/StianOvrevage) made their first contribution in prometheus-community/helm-charts#3798 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.9.3...kube-prometheus-stack-51.9.4 ### [`v51.9.3`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.9.3) [Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-51.9.2...kube-prometheus-stack-51.9.3) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Fix etcd dashboards by [@​QuentinBisson](https://github.com/QuentinBisson) in prometheus-community/helm-charts#3917 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.9.2...kube-prometheus-stack-51.9.3 ### [`v51.9.2`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.9.2) [Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-51.9.1...kube-prometheus-stack-51.9.2) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] fixes thanos ruler object store configs by [@​thameezb](https://github.com/thameezb) in prometheus-community/helm-charts#3913 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-51.9.1...kube-prometheus-stack-51.9.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNy4wIiwidXBkYXRlZEluVmVyIjoiMzcuMjcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/160 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
1 task
1 task
1 task
Closed
1 task
Closed
1 task
Matiasmct
pushed a commit
to giffgaff/prometheus-charts
that referenced
this pull request
Mar 20, 2024
…nity#3798) Signed-off-by: Stian Øvrevåge <sovrevage@gmail.com> Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
#1730 adds a hardcoded
job="coredns"selector to all queries to exclude node local dns.We would actually like to use this dashboard for viewing GKE NodeLocal DNSCache metrics (which uses coredns and exposes it's metrics).
This PR adds a template variable
jobto the dashboard and replacesjob="coredns"withjob=~"$job"in all queries.This should allow for selectively excluding node local dns, but not require it.
@andrewgkew @gianrubio @gkarthiks @GMartinez-Sisti @scottrigby @Xtigyro @QuentinBisson
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])