[prometheus-node-exporter] feat: allow changing the default revisionHistoryLimit

[tberreis]

What this PR does / why we need it

You may want to clean up old ReplicaSets so that these don't appear in metrics, OPA violations, ArgoCD UI and so on.
Therefore you want to overwrite the Kubernetes default revision history limit.

The Prometheus Node Exporter DaemonSet has been adapted to allow the user changing the default revisionHistoryLimit.

Which issue this PR fixes

N/A

Special notes for your reviewer

N/A

Checklist

• DCO signed
• Chart Version bumped
• Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

[zeritti]

Thank you, @tberreis, for your PR.

[rouke-broersma]

@tberreis fyi we are running a custom admission controller that sets the revision history limit to 0 for all deployments etc in the cluster. It would have been better if instead of forcing the revision history limit to 10 you would have made it so the revision history limit is only set if set by the user. Now we are getting sync-loops in argocd until we set the revision history limit to 0 manually in the values. Not a big deal but setting the default in the chart is kind of a breaking change and it's not really neccesary.

[tberreis]

@tberreis fyi we are running a custom admission controller that sets the revision history limit to 0 for all deployments etc in the cluster. It would have been better if instead of forcing the revision history limit to 10 you would have made it so the revision history limit is only set if set by the user. Now we are getting sync-loops in argocd until we set the revision history limit to 0 manually in the values. Not a big deal but setting the default in the chart is kind of a breaking change and it's not really neccesary.

Totally agree! That's how I started with this topic but on some repositories I had to remove the conditional (see kubereboot/charts#47 (review) for example).
Therefore I decided to use the Kubernetes defaults here. Sorry to hear that it broke your customization.

[rouke-broersma]

It's not a big deal and I appreciate that someone is going around making the revision history limit configurable 😁