[kube-prometheus-stack] Allow changing the default revisionHistoryLimit #3664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barney71
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
Signed-off-by: Thomas Krawczyk <thomas.krawczyk@diva-e.com>
barney71
force-pushed
the
feat/add-allow-changing-revisionHistoryLimit
branch
from
870ce21
to
76b9c5d
Compare
Xtigyro
approved these changes
Aug 4, 2023
|
@barney71 Thank you! |
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Aug 5, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kube-prometheus-stack](https://github.com/prometheus-operator/kube-prometheus) ([source](https://github.com/prometheus-community/helm-charts)) | minor | `48.2.3` -> `48.3.1` | --- ### Release Notes <details> <summary>prometheus-community/helm-charts (kube-prometheus-stack)</summary> ### [`v48.3.1`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-48.3.1) [Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-48.3.0...kube-prometheus-stack-48.3.1) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Fix indentation multiple imagePullSecrets by [@​DanielBronk](https://github.com/DanielBronk) in prometheus-community/helm-charts#3666 #### New Contributors - [@​DanielBronk](https://github.com/DanielBronk) made their first contribution in prometheus-community/helm-charts#3666 **Full Changelog**: prometheus-community/helm-charts@prometheus-operator-crds-5.1.0...kube-prometheus-stack-48.3.1 ### [`v48.3.0`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-48.3.0) [Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-48.2.3...kube-prometheus-stack-48.3.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Allow changing the default revisionHistoryLimit by [@​barney71](https://github.com/barney71) in prometheus-community/helm-charts#3664 #### New Contributors - [@​barney71](https://github.com/barney71) made their first contribution in prometheus-community/helm-charts#3664 **Full Changelog**: prometheus-community/helm-charts@prometheus-adapter-4.3.1...kube-prometheus-stack-48.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yMy4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/33 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
|
@barney71 - this worked great for the operator! How would changes to I tried this, was ignored: |
|
Hi @reefland, alertmanger kube-state-metrics prometheus prometheus-node-exporter prometheus-operator-admission-webhook grafana - already support setting deployment's revisionHistoryLimit |
Matiasmct
pushed a commit
to giffgaff/prometheus-charts
that referenced
this pull request
Aug 25, 2023
…munity#3664) Signed-off-by: Thomas Krawczyk <thomas.krawczyk@diva-e.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
I want to clean up old replica sets so that these don't appear in metrics, OPA violations, ArgoCD UI and so on.
Therefore I want to overwrite the Kubernetes default revision history limit.
See Kubernetes Clean up Policy.
Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])