[prometheus-operator-admission-webhook] feat: allow changing the default revisionHistoryLimit #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Berreis <thomas@berreis.de>
3 tasks
Matiasmct
pushed a commit
to giffgaff/prometheus-charts
that referenced
this pull request
Aug 25, 2023
…munity#3678) Signed-off-by: Thomas Berreis <thomas@berreis.de> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
You may want to clean up old ReplicaSets so that these don't appear in metrics, OPA violations, ArgoCD UI and so on.
Therefore you want to overwrite the Kubernetes default revision history limit.
The Prometheus Operator Admission Webhook Depoyment has been adapted to allow the user changing the default revisionHistoryLimit.
Which issue this PR fixes
N/A
Special notes for your reviewer
N/A
Checklist
[prometheus-couchdb-exporter])