Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support modules configuration #146

Merged
merged 4 commits into from
May 27, 2022
Merged

Support modules configuration #146

merged 4 commits into from
May 27, 2022

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Mar 22, 2022 •
edited
Loading

Signed-off-by: Ben Ye ben.ye@bytedance.com

Fixes #86

This PR supports modules configuration. Similar to black-box exporter, scrape requests can add a module parameter to specify which module to use. If not specified, default module will be used.

@yeya24
Copy link
Contributor Author

yeya24 commented Mar 22, 2022

Any maintainer/reviewers for this repo? Maybe cc @SuperQ?

@SuperQ SuperQ requested review from rustycl0ck and SuperQ May 22, 2022 20:21
@SuperQ
Copy link
Contributor

SuperQ commented May 22, 2022

Sorry I missed this review ping. This is a great idea. I'll give it a look over asap.

SuperQ
SuperQ reviewed May 22, 2022
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
rustycl0ck
rustycl0ck reviewed May 23, 2022
View reviewed changes
Copy link
Member

@rustycl0ck rustycl0ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Please update the Readme documentation as well.

SuperQ
SuperQ requested changes May 23, 2022
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the example config(s) in the README.

examples/config.yml Outdated Show resolved Hide resolved
@yeya24
Copy link
Contributor Author

yeya24 commented May 24, 2022

I have updated the doc. PTAL.

Ben Ye added 3 commits May 23, 2022 22:29
support modules configuration
9e1e16a 
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
fallback default module if the param is missing
fe8a8b9 
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
update readme and example config file
f396d98 
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
fix lint
e342d92 
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
SuperQ
SuperQ approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ requested a review from rustycl0ck May 24, 2022 08:15
@yeya24
Copy link
Contributor Author

yeya24 commented May 27, 2022

Please take another look @rustycl0ck thank you!

rustycl0ck
rustycl0ck approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@rustycl0ck rustycl0ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rustycl0ck rustycl0ck merged commit 75ae2b0 into prometheus-community:master May 27, 2022
@yeya24 yeya24 deleted the support-module branch May 27, 2022 06:00
@sepich sepich mentioned this pull request Jun 20, 2022
Closed
SuperQ added a commit that referenced this pull request Jul 3, 2022
@SuperQ
Release v0.5.0
a859faf 
Breaking Change:

The exporter config file format has changed. It now supports multiple modules
to scrape different endpoints.

* [FEATURE] Support custom valuetype #145
* [FEATURE] Support modules configuration #146

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Jul 3, 2022
Merged
SuperQ added a commit that referenced this pull request Jul 11, 2022
@SuperQ
Release v0.5.0
59477d6 
Breaking Change:

The exporter config file format has changed. It now supports multiple modules
to scrape different endpoints.

* [FEATURE] Support custom valuetype #145
* [FEATURE] Support modules configuration #146
* [FEATURE] Accept non-2xx HTTP status #161

Signed-off-by: SuperQ <superq@gmail.com>
SuperQ added a commit that referenced this pull request Jul 11, 2022
@SuperQ
Release v0.5.0 (#166)
2c1ca88 
Breaking Change:

The exporter config file format has changed. It now supports multiple modules
to scrape different endpoints.

* [FEATURE] Support custom valuetype #145
* [FEATURE] Support modules configuration #146
* [FEATURE] Accept non-2xx HTTP status #161

Signed-off-by: SuperQ <superq@gmail.com>
@rustycl0ck rustycl0ck mentioned this pull request Nov 30, 2022
Open
@elohmeier elohmeier mentioned this pull request Jan 2, 2023
Merged
13 tasks
teutat3s added a commit to teutat3s/nixpkgs that referenced this pull request May 19, 2023
@teutat3s
nixosTests.prometheus-exporters.json: fix test script
1d556fd 
Upstream changed the config format in prometheus-community/json_exporter#146
@teutat3s teutat3s mentioned this pull request May 19, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustycl0ck rustycl0ck rustycl0ck approved these changes

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi probe target with different username/password
3 participants
@yeya24 @SuperQ @rustycl0ck