Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement healthcheck for kubernetes probes #106

Merged
merged 1 commit into from
Jun 2, 2022
Merged

feat: implement healthcheck for kubernetes probes #106

merged 1 commit into from
Jun 2, 2022

Conversation

jkroepke
Copy link
Member

@jkroepke jkroepke commented Jun 1, 2022

Alternate to TCP based probes for kubernetes

@jkroepke
feat: implement healthcheck for kubernetes probes
66695d9 
Signed-off-by: Jan-Otto Kröpke <jok@cloudeteer.de>
squat
squat approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds nice :)

I'm working on a PR to actually instrument the prom-label-proxy and expose metrics on an internal HTTP server. Once that's in place, we should probably move this handler there, however this is fine for now 👍

@squat squat merged commit a46da29 into prometheus-community:master Jun 2, 2022
@jkroepke jkroepke deleted the healthz branch June 2, 2022 11:19
@jkroepke
Copy link
Member Author

jkroepke commented Jun 2, 2022

Thanks @squat . I would really appreciate it, if this could be released soon. 👍

@jkroepke jkroepke mentioned this pull request Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkroepke @squat