feat: Send errors in prometheus rest api format #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squat
reviewed
Jun 7, 2022
squat
reviewed
Jun 7, 2022
squat
reviewed
Jun 7, 2022
squat
reviewed
Jun 7, 2022
|
I hope, everything is fine now. |
squat
reviewed
Jun 8, 2022
Signed-off-by: Jan-Otto Kröpke <jok@cloudeteer.de>
squat
approved these changes
Jun 15, 2022
|
Thanks for working on this @jkroepke 🎉 |
Kirchen99
pushed a commit
to Kirchen99/prom-label-proxy
that referenced
this pull request
Jun 17, 2022
…#108) Signed-off-by: Jan-Otto Kröpke <jok@cloudeteer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the format of all error related http responses.
Instead send error as plain text, capsule the error into a json that follows normal prometheus API responses. https://prometheus.io/docs/prometheus/latest/querying/api/#http-api
The motivations of this change is to make errors visible in Grafana. Otherwise, errors are hard to debug, since the errors are not logged.
Before:
After:
