fix: correct smartctl_device_bytes_written & smartctl_device_bytes_read for NVMe #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neurodrone
approved these changes
Mar 6, 2024
…ad for NVMe The NVMe specification says that the controller is responsible for reporting "Data Units Read" & "Data Units Written" converted as needed for logicial block sizes other than 512-bytes. smartmontools already has the correct behavior. What is correct in this case? For now, track what smartmontools does: take the counter, multiply by 512*1000, report the value. We should be clear that it means the drive has read/written at most that many bytes. This has a few impacts: - NVME devices will now show these metrics, if they did not before. - NVME devices with blocksize other than 512-bytes may have previously reported inflated metrics, but are now corrected (is this worthy of larger notice in changelogs?) Reference: https://github.com/smartmontools/smartmontools/blob/11415ee0b9d5f4a22ddfb3722fdfb05e72372a03/smartmontools/nvmeprint.cpp#L394-L397 Closes: prometheus-community#122 Signed-off-by: Robin H. Johnson <rjohnson@coreweave.com>
|
@SuperQ bump |
|
@SuperQ bump again |
SuperQ
approved these changes
Apr 9, 2024
uhthomas
added a commit
to uhthomas/automata
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NVMe specification says that the controller is responsible for reporting "Data Units Read" & "Data Units Written" converted as needed for logicial block sizes other than 512-bytes. smartmontools already has the correct** behavior.
What is correct in this case? For now, track what smartmontools does: take the counter, multiply by 512*1000, report the value.
We should be clear that it means the drive has read/written at most that many bytes.
This has a few impacts:
Reference: https://github.com/smartmontools/smartmontools/blob/11415ee0b9d5f4a22ddfb3722fdfb05e72372a03/smartmontools/nvmeprint.cpp#L394-L397
Closes: #122