Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated flags: --collector.*.*-blacklist / --collector.*.*-whitelist #1337

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

jkroepke
Copy link
Member

This PR removing deprecated flags (blacklist, whitelist) + deprecated flag on textfile collector.

Since our major version is still <1, the breaking change is acceptable. If not, we can postpone this.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke requested a review from a team as a code owner November 15, 2023 18:18
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd previously committed to removing these in the v0.26.0 release of the exporter, though I feel enough time has passed to warrant the removal of the deprecated flags.

Feel free to merge this now or wait until after v0.25.0 is released.

@jkroepke jkroepke changed the title Remove deprecated flags Remove deprecated flags: --collector.*.*-blacklist / --collector.*.*-whitelist Nov 17, 2023
@jkroepke jkroepke merged commit c6b6a23 into prometheus-community:master Nov 17, 2023
5 checks passed
@jkroepke jkroepke deleted the remove-old-flags branch November 17, 2023 15:20
@DiniFarb DiniFarb mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants