textfile_dir not inst

[irnmn]

use command msiexec /i windows_exporter-0.25.0-amd64.msi ENABLED_COLLECTORS="cpu,cs,iis,logical_disk,memory,net,os,process,scheduled_task,service,system,tcp,textfile" LISTEN_PORT="9182" TEXTFILE_DIR="C:\custom_metrics" freezing process in progress
But if you run without the last command, then everything is successful

[DiniFarb]

This my fault, because as I was implementing #1262 (v0.24.0) I forgot to update the wxs

windows_exporter/installer/windows_exporter.wxs

Lines 47 to 48 in 6ede10e

	<Property Id="TEXTFILE_DIR" Secure="yes" />
	<SetProperty Id="TextfileDirFlag" After="InstallFiles" Sequence="execute" Value="--collector.textfile.directory [TEXTFILE_DIR]" Condition="TEXTFILE_DIR" />

With #1262 the flag --collector.textfile.directory was marked deprecated and then in the next release removed by #1337 (v0.25.0)

@breed808 should I bump in a PR to fix? If so my question would be, should I also update the ID like Id="TEXTFILE_DIRS" instead of Id="TEXTFILE_DIR"

[breed808]

Yes please, a PR is welcome. I'd go with Id="TEXTFILE_DIRS" as that clearly indicates that multiple directories can be supplied. The TEXTFILE_DIR reference in the main README will need to be updated too.

[irnmn]

will there be a new version 0.25.1 or what?

[jkroepke]

https://github.com/prometheus-community/windows_exporter/releases/tag/v0.25.1 - please let us know, if you issue is resolved

[github-actions]

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.