Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(#1382): rename TEXTFILE_DIR to TEXTFILE_DIRS #1384

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

DiniFarb
Copy link
Contributor

As announced in #1382 the according fix.

And I was wondering if deprecation warning here should be removed or changes since it argument is gone now?

### `--collector.textfile.directory`
:warning: DEPRECATED Use `--collector.textfile.directories`
<br>

Signed-off-by: Dinifarb <andreas.vogt89@bluewin.ch>
@DiniFarb DiniFarb requested a review from a team as a code owner January 12, 2024 15:51
@jkroepke jkroepke added the bug label Jan 12, 2024
…rsFlag

Signed-off-by: Dinifarb <andreas.vogt89@bluewin.ch>
@jkroepke
Copy link
Member

Thank you.

The old flag was deprecated long time, but only visible at start-up logs.

@jkroepke jkroepke merged commit 415c72d into prometheus-community:master Jan 13, 2024
2 checks passed
@DiniFarb DiniFarb deleted the issue_#1382 branch May 7, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants