Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SMTP collector #657

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Add SMTP collector #657

merged 2 commits into from
Nov 23, 2020

Conversation

breed808
Copy link
Contributor

@breed808 breed808 commented Nov 8, 2020

This implements an IIS SMTP Collector, exposing metrics for each SMTP virtual server configured on server.

As I don't have access to an in-use SMTP server at my work, I've downloaded the Windows Server 2019 evaluation ISO and installed the SMTP server on it. As such, the metrics aren't tested, and I can't confirm if their type (gauge/counter) is correct. This will need to be tested before it is merged.

Resolves #654

@carlpett
Copy link
Collaborator

carlpett commented Nov 8, 2020

Nice! I don't have any IIS-SMTP servers either (to be honest, I had to dig pretty deep in memory to remember there even was such a functionality in IIS).
The code looks good, so my only question is really if we should either be more specific about what smtp server we are collecting from (ie iis-smtp or such), or do it as a sub-collector of the existing iis collector?

@breed808
Copy link
Contributor Author

breed808 commented Nov 8, 2020

There's details for and against the current smtp name. The IIS SMTP server appears to be the only SMTP server with performance counters exposed by Windows, and therefore the only one to fall under this exporter's scope.
However, the SMTP server is managed through the IIS 6 Management console, and is therefore related to IIS in some manner.

The SMTP Server is installed with the SMTP feature, which pulls in some IIS management components in the IIS role. I think keeping the collector separate would be best, as one can have an SMTP server running, or a webserver, or both.

If we're not able to find testers, perhaps the collector could be merged with documentation stating it is in pre-release or beta state?

@carlpett
Copy link
Collaborator

I'd have thought it'd collide with Exchange? But if not, let's keep it as-is. I'm also fine with adding it marked as experimental in the docs or similar.

Signed-off-by: Ben Reedy <breed808@breed808.com>
Signed-off-by: Ben Reedy <breed808@breed808.com>
@breed808
Copy link
Contributor Author

OK, I've added an experimental note in the docs.

@breed808 breed808 marked this pull request as ready for review November 21, 2020 08:34
@breed808 breed808 requested a review from a team as a code owner November 21, 2020 08:34
Copy link
Collaborator

@carlpett carlpett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@breed808 breed808 merged commit 82471f3 into prometheus-community:master Nov 23, 2020
@breed808 breed808 deleted the smtp_collector branch November 23, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can check IIS Server status ?
2 participants