Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Api collection close servicehandler to avoid memory leak #840

Merged
merged 1 commit into from Sep 25, 2021
Merged

Service Api collection close servicehandler to avoid memory leak #840

merged 1 commit into from Sep 25, 2021

Conversation

alvarocabanas
Copy link
Contributor

  • Correct closing of service handler that was causing a memory increase over time since there were handlers kept on the heap.

@breed808, this is a fix for the feature we added on this PR #812.

@alvarocabanas alvarocabanas requested a review from a team as a code owner September 23, 2021 15:43
@alvarocabanas
Service Api collection close servicehandler to avoid memory leak
f4f5aaf 
Signed-off-by: Alvaro Cabanas <acabanas@newrelic.com>
@alvarocabanas alvarocabanas mentioned this pull request Sep 23, 2021
Closed
@carlossscastro carlossscastro mentioned this pull request Sep 24, 2021
Closed
breed808
breed808 approved these changes Sep 25, 2021
View reviewed changes
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing that 👍

@breed808 breed808 merged commit 3e37b7b into prometheus-community:master Sep 25, 2021
@carlossscastro
Copy link
Contributor

Thanks @breed808 for the quick merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breed808 breed808 breed808 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alvarocabanas @carlossscastro @breed808