Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "GroupRule" struct is missing the "limit" field. #4998

Closed
cuizhaoyue opened this issue Sep 6, 2022 · 1 comment · Fixed by #4999
Closed

The "GroupRule" struct is missing the "limit" field. #4998

cuizhaoyue opened this issue Sep 6, 2022 · 1 comment · Fixed by #4999

Comments

@cuizhaoyue
Copy link

What happened?
I can't create a alerting rule with the "limit" field so that I can't limit the number of alerts an alerting can produce.

Did you expect to see something different?

How to reproduce it (as minimally and precisely as possible):

Environment

  • Prometheus Operator version:

    v0.59.0

  • Kubernetes version information:

    Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-07T21:20:10Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-07T21:12:17Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}

  • Kubernetes cluster kind:

    insert how you created your cluster: kops, bootkube, etc.

  • Manifests:

insert manifests relevant to the issue
  • Prometheus Operator Logs:
insert Prometheus Operator logs relevant to the issue here

Anything else we need to know?:
the offical Prometheus is support the limit field in group_rule section.
Reference: https://prometheus.io/docs/prometheus/latest/configuration/recording_rules/#rule_group
image

@simonpasquier
Copy link
Contributor

The limit field is supported starting with Prometheus >= 2.31 and Thanos Ruler >= 0.24.

slashpai added a commit to slashpai/prometheus-operator that referenced this issue Sep 7, 2022
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Oct 14, 2022
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Oct 14, 2022
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Oct 14, 2022
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Oct 14, 2022
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Oct 14, 2022
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Dec 12, 2022
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Dec 12, 2022
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Dec 12, 2022
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Mar 14, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Mar 14, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Mar 14, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Mar 14, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Mar 15, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Mar 16, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Mar 16, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Mar 16, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Mar 23, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Apr 18, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Apr 19, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Apr 26, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Apr 26, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Apr 26, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Apr 26, 2023
Fixes prometheus-operator#4998

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants