-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/apis: Support Prometheus RuleGroup Limit #4999
Conversation
601ea3b
to
fa7bc2a
Compare
@simonpasquier PTAL |
We need a version check when generating the rules configmaps because when Prometheus < 2.31 or Thanos < 0.24, the field should be omitted. |
@simonpasquier when can this PR merge to the main branch? I am looking for the function that support prometheus RuleGroup Limit. |
#5124 this needs to be merged so that I can update it further to do version check |
54a08d4
to
00d3368
Compare
5ed52cd
to
9b20045
Compare
f0660f4
to
b3245a2
Compare
Also, it seems you might have forgotten to run |
No I did run that. Looks like go version issue since I am using 1.19. I will update to 1.20 and format again |
cf712b9
to
4814dda
Compare
@simonpasquier @JoaoBraveCoding Addressed review comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small non-blocking nit, apart from that it's a /lgtm from my side
Good job JP! 💪
3b465a9
to
4f8aeb5
Compare
This is ready for review again :) |
@simonpasquier addressed comments |
b576352
to
5cfa200
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small nit
Fixes prometheus-operator#4998 Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Fixes #4998
Signed-off-by: Jayapriya Pai slashpai9@gmail.com
Description
Support Prometheus RuleGroup Limit
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.