Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit their parent route's grouping when "group_by: [...]" #2154

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Inherit their parent route's grouping when "group_by: [...]" #2154

merged 1 commit into from
Jan 10, 2020

Conversation

shokada
Copy link
Contributor

@shokada shokada commented Jan 3, 2020 •
edited
Loading

Fixes #1857

@shokada
Inherit their parent route's grouping when "group_by: [...]"
a9c6b91 
Signed-off-by: Sho Okada <shokada3@gmail.com>
@simonpasquier simonpasquier merged commit 04ca507 into prometheus:master Jan 10, 2020
@simonpasquier
Copy link
Member

Thanks!

@shokada
Copy link
Contributor Author

shokada commented Jan 10, 2020

Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Routes don't inherit their parent route's grouping when "group_by: [...]"
2 participants
@shokada @simonpasquier