Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify: add markdown support for wechat #2309

Merged
merged 9 commits into from
Jul 6, 2020

Conversation

deamwork
Copy link
Contributor

Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to update the wechat_config section in https://github.com/prometheus/alertmanager/blob/master/docs/configuration.md too.

config/notifiers.go Show resolved Hide resolved
notify/wechat/wechat.go Outdated Show resolved Hide resolved
notify/wechat/wechat.go Outdated Show resolved Hide resolved
notify/wechat/wechat.go Outdated Show resolved Hide resolved
notify/wechat/wechat.go Show resolved Hide resolved
Signed-off-by: Jason Cooper <master@deamwork.com>
Signed-off-by: Jason Cooper <master@deamwork.com>
Signed-off-by: Jason Cooper <master@deamwork.com>
Signed-off-by: Jason Cooper <master@deamwork.com>
Signed-off-by: Jason Cooper <master@deamwork.com>
docs/configuration.md Outdated Show resolved Hide resolved
config/notifiers.go Outdated Show resolved Hide resolved
config/notifiers.go Show resolved Hide resolved
Signed-off-by: Jason Cooper <master@deamwork.com>
Signed-off-by: Jason Cooper <master@deamwork.com>
Signed-off-by: Jason Cooper <master@deamwork.com>
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one final request and it should be ok :)

notify/wechat/wechat.go Show resolved Hide resolved
Signed-off-by: Jason Cooper <master@deamwork.com>
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simonpasquier simonpasquier merged commit 277c9ed into prometheus:master Jul 6, 2020
@deamwork
Copy link
Contributor Author

deamwork commented Jul 6, 2020

And a little question here:
Is this project a CNCF project?

@simonpasquier
Copy link
Member

@deamwork yes it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants