Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading Telegram bot token from file #3226

Merged
merged 1 commit into from Apr 6, 2023
Merged

Support loading Telegram bot token from file #3226

merged 1 commit into from Apr 6, 2023

Conversation

an5t
Copy link
Contributor

@an5t an5t commented Jan 22, 2023

Adds support for loading Telegram bot token from file.

This PR is mainly inspired by #3131. I've made a few changes considering the conversation in #3131, done minor refactoring, added some tests, and rebased changes to the current main.

Signed-off-by: Andrey Mishakin <stieroglif@gmail.com>
Copy link

@KFearsoff KFearsoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do you mind if this PR overtakes #3131, and we get the final push to merge this?

@an5t
Copy link
Contributor Author

an5t commented Apr 5, 2023

I'm interested in this feature was merged one way or another. Is there anything else I can to do to make this happen?

Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simonpasquier simonpasquier merged commit bb1c123 into prometheus:main Apr 6, 2023
@simonpasquier
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants