Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define a RELEASE.MD for the Alertmanager Project #3344

Closed
wants to merge 39 commits into from
Closed

Define a RELEASE.MD for the Alertmanager Project #3344

wants to merge 39 commits into from

Conversation

gotjosh
Copy link
Member

@gotjosh gotjosh commented Apr 28, 2023

Will helps us get to a more regular cadance of releases.

@gotjosh
Define a RELEASE.MD for the Alertmanager Project
eb3ca5a 
Will helps us get to a more regular cadance of releases.

Signed-off-by: gotjosh <josue.abreu@gmail.com>
@gotjosh
bump cadence to 3 months
b861489 
Signed-off-by: gotjosh <josue.abreu@gmail.com>
@roidelapluie
Copy link
Member

The release.md of Prometheus should cover the procedure for all repos. What's needed here is the schedule and the table I guess.

@gotjosh
Copy link
Member Author

gotjosh commented Apr 28, 2023

My plan is to go through the instructions (I haven't done my first release) and document along the way if I find something that does not add up.

My reason for copying the responsibilities is that I found:

With the pre-release, the release shepherd is responsible for running and monitoring a benchmark run of the pre-release for 3 days, after which, if successful, the pre-release is promoted to a stable release.

Does not really apply to us - we don't have the equivalent of a prombench. However, I don't think that's stopping us from exercising best judgement.

That said, I agree that we should just reference to the Prometheus file to keep things consistent.

@gotjosh
refer back to the prometheus release.md
b6ae733 
Signed-off-by: gotjosh <josue.abreu@gmail.com>
@gotjosh
Copy link
Member Author

gotjosh commented May 5, 2023

@simonpasquier @roidelapluie friendly ping - any thoughts?

mkreidenweis-schulmngr
mkreidenweis-schulmngr reviewed Jun 9, 2023
View reviewed changes
RELEASE.md Outdated

| release series | date (year-month-day) | release shepherd |
|----------------|-----------------------|-------------------------------|
| v0.26 | 2023-05-31 | Josh Abreu (Github: @gotjosh) |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any news on an actual release? This date looked promising. ;-)

I'd really like to use #3226

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently waiting on #3353 as I know this will be quite a big release, I'd love for users to to try and enable that as well. We're closer now than ever ❤️

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like there was any progress on #3353 in the past 7 weeks. Do we really need to wait for that PR to be included in the next release?

simonpasquier
simonpasquier approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

RELEASE.md Outdated
| release series | date (year-month-day) | release shepherd |
|----------------|-----------------------|-------------------------------|
| v0.26 | 2023-05-31 | Josh Abreu (Github: @gotjosh) |
| v0.27 | 2023-08-31 | Josh Abreu (Github: @gotjosh) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can sign me up for this one if you don't want to do twice in a row

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to do it twice in a row - you can take the third.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhan9san
Copy link
Contributor

zhan9san commented Jul 4, 2023

Hi team,

Thank you for your time and dedication to maintaining this project.

I appreciate your support and look forward to seeing #3324 in the upcoming release.

It seems that the release process is stuck for over 2 months. Is there anything I can help?

I am glad to get involved if needed.

r0nn and others added 21 commits August 7, 2023 10:45
@r0nn @gotjosh
fix wechat notifier response field name (#3330)
6bfc224 
Signed-off-by: gotjosh <josue.abreu@gmail.com>
@gotjosh
add reason code to slack notifier (#3252)
2d22f2f 
* add reason code to slack notifier
this uses the new error with reason to determine based on status code what the reason is for the slack integration

partial #3231

Signed-off-by: gotjosh <josue.abreu@gmail.com>

* Add some tests

Signed-off-by: gotjosh <josue.abreu@gmail.com>

* Handle the error

Signed-off-by: gotjosh <josue.abreu@gmail.com>

---------

Signed-off-by: gotjosh <josue.abreu@gmail.com>
@fgouteroux @gotjosh
fix: change receiver model pointer to value (#3338)
7773f06 
* fix: change receiver pointer to value and add test

Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
---------

Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
@dependabot @gotjosh
Bump gopkg.in/telebot.v3 from 3.1.2 to 3.1.3
cf11f5d 
Bumps gopkg.in/telebot.v3 from 3.1.2 to 3.1.3.

---
updated-dependencies:
- dependency-name: gopkg.in/telebot.v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @gotjosh
Bump golang.org/x/text from 0.8.0 to 0.9.0
d433ed5 
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.8.0...v0.9.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @gotjosh
Bump github.com/prometheus/client_golang from 1.14.0 to 1.15.0
74fd523 
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.14.0...v1.15.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @gotjosh
Bump github.com/benbjohnson/clock from 1.3.0 to 1.3.3
df42734 
Bumps [github.com/benbjohnson/clock](https://github.com/benbjohnson/clock) from 1.3.0 to 1.3.3.
- [Release notes](https://github.com/benbjohnson/clock/releases)
- [Commits](benbjohnson/clock@v1.3.0...v1.3.3)

---
updated-dependencies:
- dependency-name: github.com/benbjohnson/clock
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @gotjosh
Bump github.com/rs/cors from 1.8.3 to 1.9.0
597baef 
Bumps [github.com/rs/cors](https://github.com/rs/cors) from 1.8.3 to 1.9.0.
- [Release notes](https://github.com/rs/cors/releases)
- [Commits](rs/cors@v1.8.3...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/rs/cors
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@gotjosh
Slack Notifier: Only return an error when it actually occurs (#3350)
4de7524
@alec-pinson @gotjosh
Add support for pushover devices (#3318)
3d0739f 
* Add support for pushover devices

Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>

* update docs

Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>

---------

Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>
@simonpasquier @gotjosh
docs: document the new proxy-related settings
4dee088 
The version of `github.com/prometheus/common` imported by Alertmanager
adds several fields to the `http_config` and `oauth2` structs for
setting proxy parameters:
* `no_proxy`
* `proxy_from_environment`
* `proxy_connect_header`

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@emanlodovice @gotjosh
api/v2: Delete silence respond with 404 when silence is not found (#3352
0d4533a 
)

Signed-off-by: Emmanuel Lodovice <lodovice@amazon.com>
@JohnnyQQQQ @gotjosh
Cluster: Add memberlist label configuration option (#3354)
60b0416 
* Cluster: Add memberlist label configuration option

Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com>

---------

Signed-off-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com>
Signed-off-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
@grobinson-grafana @gotjosh
Add tests to TestMatchers (#3357)
08371b6 
* Add tests to TestMatchers

This commit adds a number of tests to TestMatchers that asserts
some of the more nuanced behavior when parsing label matchers.

Signed-off-by: George Robinson <george.robinson@grafana.com>

---------

Signed-off-by: George Robinson <george.robinson@grafana.com>
@grobinson-grafana @gotjosh
Add more tests to TestMatchers (#3362)
80cbee0 
Signed-off-by: George Robinson <george.robinson@grafana.com>
@b1zzu @gotjosh
notify/webhook: trim space from url_file content
6b3dbc1 
Signed-off-by: Davide Bizzarri <davide.bizzarri@neoom.com>
@dependabot @gotjosh
Bump golang.org/x/net from 0.8.0 to 0.10.0
33d8f0b 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.10.0.
- [Commits](golang/net@v0.8.0...v0.10.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @gotjosh
Bump github.com/cenkalti/backoff/v4 from 4.2.0 to 4.2.1
d292d75 
Bumps [github.com/cenkalti/backoff/v4](https://github.com/cenkalti/backoff) from 4.2.0 to 4.2.1.
- [Commits](cenkalti/backoff@v4.2.0...v4.2.1)

---
updated-dependencies:
- dependency-name: github.com/cenkalti/backoff/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @gotjosh
Bump go.uber.org/atomic from 1.10.0 to 1.11.0
90f63fb 
Bumps [go.uber.org/atomic](https://github.com/uber-go/atomic) from 1.10.0 to 1.11.0.
- [Release notes](https://github.com/uber-go/atomic/releases)
- [Changelog](https://github.com/uber-go/atomic/blob/master/CHANGELOG.md)
- [Commits](uber-go/atomic@v1.10.0...v1.11.0)

---
updated-dependencies:
- dependency-name: go.uber.org/atomic
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @gotjosh
Bump github.com/go-openapi/runtime from 0.25.0 to 0.26.0
74f2ede 
Bumps [github.com/go-openapi/runtime](https://github.com/go-openapi/runtime) from 0.25.0 to 0.26.0.
- [Release notes](https://github.com/go-openapi/runtime/releases)
- [Commits](go-openapi/runtime@v0.25.0...v0.26.0)

---
updated-dependencies:
- dependency-name: github.com/go-openapi/runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @gotjosh
Bump github.com/prometheus/client_golang from 1.15.0 to 1.15.1
850cdc8 
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.15.0 to 1.15.1.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.15.0...v1.15.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
dependabot bot and others added 15 commits August 7, 2023 10:45
@dependabot @gotjosh
Bump github.com/prometheus/exporter-toolkit from 0.9.1 to 0.10.0
4935180 
Bumps [github.com/prometheus/exporter-toolkit](https://github.com/prometheus/exporter-toolkit) from 0.9.1 to 0.10.0.
- [Release notes](https://github.com/prometheus/exporter-toolkit/releases)
- [Changelog](https://github.com/prometheus/exporter-toolkit/blob/master/CHANGELOG.md)
- [Commits](prometheus/exporter-toolkit@v0.9.1...v0.10.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/exporter-toolkit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@grobinson-grafana @gotjosh
Document difference between tab and newline in tests (#3383)
7f9bd33 
Signed-off-by: George Robinson <george.robinson@grafana.com>
@zhan9san @gotjosh
Add msteams (#3324)
a8c3cfb 
* Add msteams

Signed-off-by: Jack Zhang <jack4zhang@gmail.com>
---------
Signed-off-by: Jack Zhang <jack4zhang@gmail.com>
Signed-off-by: Jack <jack4zhang@gmail.com>
@grobinson-grafana @gotjosh
Log a warning when repeat_interval is less than group_interval (#3389)
402ab5a 
* Log a warning when repeat_interval is less than group_interval

This commit updates Alertmanager to log a warning when
repeat_interval is less than group_interval for an individual route.

When repeat_interval is less than group_interval, the earliest
a notification can be sent again is the next time the aggregation
group is flushed, and this happens at each group_interval.

Signed-off-by: George Robinson <george.robinson@grafana.com>
---------

Signed-off-by: George Robinson <george.robinson@grafana.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
@maheshvidhyadharan @gotjosh
fixing the field name for pagerduty image_config as per code https://…
5c330a9 
…pkg.go.dev/github.com/prometheus/alertmanager/config\#PagerdutyImage

Signed-off-by: Mahesh Vidhyadharan <mahesh.vidhyadharan@steel-eye.com>
@prombot @gotjosh
Update common Prometheus files
a8d3f2f 
Signed-off-by: prombot <prometheus-team@googlegroups.com>
@kellinm @gotjosh
Build with Go 1.20
444772f 
- Start using Go 1.20 toolchain to build
- Remove deprecated reference to updating .travis.yml

Signed-off-by: Kellin <kellin@retromud.org>
@dependabot @gotjosh
Bump github.com/prometheus/common from 0.42.0 to 0.44.0
8e2ef2c 
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.42.0 to 0.44.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.42.0...v0.44.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@alvinlin123 @gotjosh
Update email.html to use "https://schema.org" instead of "https://sch…
1e0af4d 
…ema.org" (#3420)

According to schema.org's faq both https and http are fine, but https is preferred going forward: https://schema.org/docs/faq.html#19

Why am I making this change? To make some security code scanner happy :)

Signed-off-by: Alvin Lin <alvinlin123@gmail.com>
@grobinson-grafana @gotjosh
Fix example matchers in docs
df826c1 
Signed-off-by: George Robinson <george.robinson@grafana.com>
@gotjosh
Mixin: Pin the mixtool version in CircleCI
e75bb34 
In mixtool, the tip of master broke for our mixin - I have managed to trace it down and opened a PR (see grafana/dashboard-linter#143) but for now, let's pin the version to make sure our CI is not affected.

Signed-off-by: gotjosh <josue.abreu@gmail.com>
@gotjosh
update the circleCI go orb
004585a 
Signed-off-by: gotjosh <josue.abreu@gmail.com>
@simonpasquier @gotjosh
Update email assets after #3420 (#3440)
e2e6dc5 
* Add template/email.tmpl to the clean target

The change ensures that all assets can be regenerated from scratch in
the CI.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

* Update email assets after #3420

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

---------

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier @gotjosh
cluster: fix panic when tls_client_config is empty
e64a923 
Closes #3403

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@gotjosh
Update release dates
735239a 
Signed-off-by: gotjosh <josue.abreu@gmail.com>
@gotjosh gotjosh mentioned this pull request Aug 7, 2023
Merged
@gotjosh
Copy link
Member Author

gotjosh commented Aug 7, 2023

Superseded by #3445

@gotjosh gotjosh closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier approved these changes

@mkreidenweis-schulmngr mkreidenweis-schulmngr mkreidenweis-schulmngr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet