Make sure Matchers are always ordered #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks! |
iksaif
force-pushed
the
dedup-matchers
branch
2 times, most recently
from
a49248c
to
12897de
Compare
|
(removing spurious change (templates/bindata)) |
This fixes prometheus#881 Also add some unit tests
|
Ok looks good now, one of the existing tests in dispatch_test.go might be flacky |
Closed
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Apr 4, 2018
Update for 0.16.0-rc.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #881
Also add some unit tests