Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable labels #932

Merged
merged 2 commits into from
Jul 31, 2017
Merged

Selectable labels #932

merged 2 commits into from
Jul 31, 2017

Conversation

w0rm
Copy link
Member

@w0rm w0rm commented Jul 28, 2017

I think that the best way to address #887 is to have split buttons, with a text portion and a clickable element. This way we don't mess with accessibility.

I also fixed #886, because the grouping labels are very similar to the ones from the alert list.

Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is sweet, I like it

@stuartnelson3
Copy link
Contributor

Would be good to get some other opinions:

@beorn7 @grobie @mxinden @fabxc @brancz @brian-brazil if any of you have time to check out the new button interaction, would be cool

@mxinden
Copy link
Member

mxinden commented Jul 28, 2017

@w0rm I think this is a very sound solution to #887.

As a usability suggestion, can we replace the plus symbol by a filter symbol like e.g. http://fontawesome.io/icon/filter/? In addition we could put the symbol next to the string Filter in the tab component. This connects the two, so users know if they click the filter icon on a label, it will be added to the filter tab on the top. What do you think?

@w0rm
Copy link
Member Author

w0rm commented Jul 29, 2017

@mxinden I don't like this icon, I think it doesn't represent an action of adding a matcher to the filter list. Alternatively we could use a magnifying glass with a plus, but I think a tooltip is enough.

@grobie
Copy link
Member

grobie commented Jul 30, 2017

I didn't immediately grasp the elements, but it seems to be a pretty clear interface actually. I find the plus sign a clear icon for the action. In case there is a more common one for that scenario, I wouldn't mind though.

Feature request: It would be helpful to easily select the label value with a single click/double click. Maybe by changing the selection behavior so that a double click inside the value string selects everything between the quotes.

@stuartnelson3
Copy link
Contributor

@grobie feature requests belong in issues :)

@stuartnelson3
Copy link
Contributor

Unless we here a strong "no" from someone, I'm going to merge this in 24 hours. I think we agree that it's an improvement, and if we decide that a different icon would be preferable, we can easily change that.

@stuartnelson3 stuartnelson3 merged commit 7de7cf3 into master Jul 31, 2017
@stuartnelson3 stuartnelson3 deleted the selectable-labels branch July 31, 2017 11:22
@w0rm w0rm mentioned this pull request Jul 31, 2017
iksaif pushed a commit to iksaif/alertmanager that referenced this pull request Sep 15, 2017
* Make the labels selectable

* Update bindata.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the grouping label clickable, too (to move them into the filter box).
4 participants