-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This is in line with https://prometheus.io/docs/instrumenting/writing_clientlibs/#metric-description-and-help Since the zero value of a string in Go is `""`, we cannot distinguish between a Help string not set and an empty Help string. Thus, we just make it formally optional here with an encouragement to set it in the doc comment. In v0.10, the Help string will probably become a "normal" argument of the constructor rather than a field in an Opts struct. Signed-off-by: beorn7 <beorn@soundcloud.com>
- Loading branch information
beorn7
committed
Sep 17, 2018
1 parent
713e6eb
commit 663a9ad
Showing
5 changed files
with
14 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters