Un-export prometheus.LabelPairSorter #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only known external usage of it was in prometheus/pushgateway, where it was removed by prometheus/pushgateway#200 . Originally, the expectation was that users would implement the Metric interface now and then. As we know now, neither it is happening, nor would it make a lot of sense. (Users implement the Collector interface instead.) By now, LabelPairSorter is essentially noise in the already quite cluttered namespace in the prometheus package. Signed-off-by: beorn7 <beorn@soundcloud.com>
grobie
approved these changes
Sep 3, 2018
|
@beorn7 this is also being used here https://github.com/kubernetes/kube-state-metrics/blob/master/pkg/collectors/testutils/testutils.go |
|
Hmm, the Sourcegraph search doesn't seem to have good coverage...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only known external usage of it was in prometheus/pushgateway,
where it was removed by
prometheus/pushgateway#200 .
Originally, the expectation was that users would implement the Metric
interface now and then. As we know now, neither it is happening, nor
would it make a lot of sense. (Users implement the Collector interface
instead.) By now, LabelPairSorter is essentially noise in the already
quite cluttered namespace in the prometheus package.
Signed-off-by: beorn7 beorn@soundcloud.com