Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushgateway exposition: properly handle empty label values in grouping key #546

Closed
beorn7 opened this issue May 13, 2020 · 0 comments · Fixed by #547
Closed

Pushgateway exposition: properly handle empty label values in grouping key #546

beorn7 opened this issue May 13, 2020 · 0 comments · Fixed by #547

Comments

@beorn7
Copy link
Member

beorn7 commented May 13, 2020

See prometheus/pushgateway#346 for a documentation update for the PGW about empty label values in the grouping key. (Note: It's really just documenting the current state of the PGW. No change of behavior of the PGW involved.)

The code in exposition.py currently accepts empty label values for the grouping key. However, it then attempts to push in an invalid way, see prometheus/pushgateway#344 for details (the issue demonstrates it with client_golang, but presumably client_python would show exactly the same behavior).

While the use case for empty label values in the grouping key is somewhat esoteric, a case can be made for it. Thus, we should probably support it in the way now documented. Alternative is to disallow it in exposition.py. Just the current state of pretending it works but then fail to push is clearly a bug.

brian-brazil added a commit that referenced this issue May 15, 2020
Fixes #546

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
brian-brazil added a commit that referenced this issue May 15, 2020
Fixes #546

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
brian-brazil added a commit that referenced this issue May 15, 2020
Fixes #546

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant