Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#470 Add HELP output for auto-created metrics #471

Conversation

davidlukac
Copy link
Contributor

No description provided.

@davidlukac davidlukac force-pushed the feature/470-add-help-for-auto-metrics branch 3 times, most recently from 2591e3f to 6b4e959 Compare October 1, 2019 13:39
@brian-brazil
Copy link
Contributor

Could you add the DCO and a unittest?

@davidlukac davidlukac force-pushed the feature/470-add-help-for-auto-metrics branch from 6b4e959 to b50fb61 Compare October 1, 2019 13:45
@davidlukac
Copy link
Contributor Author

@brian-brazil yep, on it

@davidlukac davidlukac force-pushed the feature/470-add-help-for-auto-metrics branch from b50fb61 to d5366b0 Compare October 1, 2019 15:05
Signed-off-by: David Lukac <1215290+davidlukac@users.noreply.github.com>
@davidlukac davidlukac force-pushed the feature/470-add-help-for-auto-metrics branch from d5366b0 to 3828e1b Compare October 1, 2019 15:07
@davidlukac
Copy link
Contributor Author

@brian-brazil done

@brian-brazil brian-brazil merged commit 6214c3a into prometheus:master Oct 1, 2019
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants