Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

values: add a docstring to MultiProcessValue #514

Merged

Conversation

xavfernandez
Copy link
Contributor

To document the method as semi-supported.

Adresses #509

@xavfernandez xavfernandez force-pushed the xfernandez/document_code_path branch 2 times, most recently from fe87e17 to f492e31 Compare February 15, 2020 22:40
To document the method as semi-supported.

Signed-off-by: Xavier Fernandez <xavier.fernandez@polyconseil.fr>
@brian-brazil brian-brazil merged commit ce7063f into prometheus:master Feb 15, 2020
@brian-brazil
Copy link
Contributor

Thanks!

@xavfernandez xavfernandez deleted the xfernandez/document_code_path branch February 16, 2020 12:04
@tyler-8
Copy link

tyler-8 commented Jun 19, 2020

By the way, this contained a breaking change in some cases as it wasn't just a docstring update technically. process_identifier used to be named _pidFunc so for anyone passing that as an explicit kwarg will run in to errors.

@brian-brazil
Copy link
Contributor

The Python convention is that names beginning with an underscore are internal, thus changing or removing them is not breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants