Make 'pid' a reserved label

prometheus · Jun 12, 2019 · 922a96c · 922a96c
1 parent 22e6965
commit 922a96c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/prometheus/client/label_set_validator.rb b/lib/prometheus/client/label_set_validator.rb
@@ -6,7 +6,7 @@ module Client
     # Prometheus specification.
     class LabelSetValidator
       # TODO: we might allow setting :instance in the future
-      BASE_RESERVED_LABELS = [:job, :instance].freeze
+      BASE_RESERVED_LABELS = [:job, :instance, :pid].freeze
 
       class LabelSetError < StandardError; end
       class InvalidLabelSetError < LabelSetError; end

diff --git a/spec/prometheus/client/label_set_validator_spec.rb b/spec/prometheus/client/label_set_validator_spec.rb
@@ -37,7 +37,7 @@
     end
 
     it 'raises ReservedLabelError if a label key is reserved' do
-      [:job, :instance].each do |label|
+      [:job, :instance, :pid].each do |label|
         expect do
           validator.validate_symbols!(label => 'value')
         end.to raise_exception(described_class::ReservedLabelError)